Fix getOrInsertFunction syntax error for latest LLVM #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
requested changes
Sep 9, 2017
skeleton/Skeleton.cpp
Outdated
| ); | ||
| std::vector<Type*> paramsType = {Type::getInt32Ty(Ctx)}; | ||
| Type *retType = Type::getVoidTy(Ctx); | ||
| FunctionType *logFuncType = FunctionType::get(retType,paramsType,false); |
There was a problem hiding this comment.
Can you please use spaces between the commas in function calls?
skeleton/Skeleton.cpp
Outdated
| Constant *logFunc = F.getParent()->getOrInsertFunction( | ||
| "logop", Type::getVoidTy(Ctx), Type::getInt32Ty(Ctx), NULL | ||
| ); | ||
| std::vector<Type*> paramsType = {Type::getInt32Ty(Ctx)}; |
There was a problem hiding this comment.
A better name here is probably paramTypes, since there are multiple types. (The current name implies that it’s a single type.)
|
With this change, does everything seem to work with the latest LLVM? (Including the linker error from #12?) If so, we should probably update the README. |
|
Yeah, thanks for the advice. I'll fix the coding style. All the examples works fine with LLVM6(the latest svn trunk), so we could update the README too.
|
sampsyo
approved these changes
Sep 10, 2017
|
Awesome; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for issue #13