Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-version is not correct #88

Open
silverpill opened this issue Sep 4, 2023 · 2 comments
Open

rust-version is not correct #88

silverpill opened this issue Sep 4, 2023 · 2 comments

Comments

@silverpill
Copy link

Cargo.toml states that MSRV is 1.36.
However, since 096d851 serde_qs uses bool::then_some, which was stabilized only in Rust 1.62
@samscott89
Copy link
Owner

Good catch, thanks!

Unfortunately it wasn't possible to keep it at 1.36 due to axum using Cargo features from 1.60 in its configuration which means even though its optional it breaks package resolution :/

Fixing in #99

@silverpill
Copy link
Author

@samscott89 Thanks for update. Another place where MSRV is mentioned is Installation section of README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samscott89 @silverpill