New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert(0) is bad practice #1791

Closed

mp15 opened this issue Jun 20, 2024 · 1 comment · Fixed by #1792

Member

mp15 commented Jun 20, 2024

if you compile with NDEBUG asserts go away

htslib/synced_bcf_reader.c

Line 545 in 5f20533

assert(0);

suggest replacing with abort();

Member

pd3 commented Jun 20, 2024 •

edited

Loading

It should be fixed, thank you.

mp15 mentioned this issue

Replace assert(0) with abort() #1792

Merged

pd3 closed this as completed in #1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment