Find and listen on all available networks #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuong
reviewed
Sep 15, 2022
marcelocantos
force-pushed
the
master
branch
from
9e77252
to
e4bb70f
Compare
- To build multiple GOOS/GOOARCH combos: make build-archs
- Output to temp directory - Delete output after done building - Don't clobber alpaca binary - Clearer output (✔ prefix for successful builds)
marcelocantos
commented
Sep 16, 2022
samuong
reviewed
Sep 17, 2022
samuong
approved these changes
Sep 17, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was motivated by npm being unable to proxy through alpaca via
npm set config http://localhost:3128since node 17+ favours IPv6, whereas Go'snet.Listenfavours IPv4 when a hostname is supplied.This PR performs a hostname lookup and detects the networks (tcp4/tcp6) for all returned IPs.