Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timestamp is not included when calculate genesis block #59

Open
u4113057 opened this issue Nov 7, 2022 · 2 comments
Open

timestamp is not included when calculate genesis block #59

u4113057 opened this issue Nov 7, 2022 · 2 comments

Comments

@u4113057
Copy link

u4113057 commented Nov 7, 2022

in node_server.py at line#39 when genesis block is generated timestamp is not included (included as '0') so every genesis block has the same hash
@satwikkansal
Copy link
Owner

That is a good catch, ideally we should include a timestamp while calculating the genesis block.

@satwikkansal
Copy link
Owner

feel free to create a PR for the same if you like :)

SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
b97ba3d 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
19b3c80 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
450ad54 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
a2880d5 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
329ee8f 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
SALTWOOD added a commit to SALTWOOD/python_blockchain_app that referenced this issue Nov 11, 2023
@SALTWOOD
Changed blockchain saving logic
e57575d 
Fix: timestamp is not included when calculate genesis block (satwikkansal#59)
@SALTWOOD SALTWOOD mentioned this issue Nov 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satwikkansal @u4113057