Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate or reconsider the concept of clone markers in SBGN #248

Open
draeger opened this issue Jul 18, 2024 · 0 comments
Open

Eliminate or reconsider the concept of clone markers in SBGN #248

draeger opened this issue Jul 18, 2024 · 0 comments
Labels
Milestone

Comments

@draeger
Copy link
Collaborator

draeger commented Jul 18, 2024

The concept of clone markers is problematic and should be abandoned or changed entirely for the following reasons:

  1. These markers always highlight exactly the wrong parts of the network. In a large-scale, realistic network, we expect many currency metabolites, such as ATP or NADPH, and so forth. So, it is hard to keep track of the primary metabolites. Clone markers, however, highlight the distracting secondary metabolites.
  2. Their shape is inappropriate because they fill part of the node, making it difficult to overlay SBGN maps with measurement data. If you want to display any quantity, e.g., the concentration of some metabolite, you should remove the clone marker if it conflicts with the visualization.
  3. They are not universally applicable: The current specification does not allow clone markers for some glyphs.

I suggest rethinking this concept and considering removing it entirely or highlighting those glyphs that are not cloned rather than those that are cloned.

Originally posted by @adrienrougny in #127 (comment)

@adrienrougny adrienrougny added this to the L2+ milestone Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants