You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Somehow the coverage tool inserts the else in wrong place and make the contract non-compilable. (It failed to insert after the { of if block and inserted inside the if)
I think the root cause is I copy pasted some weird symbol to the code comment and it start to fail. And I tried to fix with this commit: omgnetwork/plasma-contracts@c7ff3eb
It was able to work locally (to compile)
Version
version: 0.7.0-beta.2
The text was updated successfully, but these errors were encountered:
cgewecke
changed the title
Solidity coverage inserting else branch to the wrong place and failed to compile
Non-ascii chars cause compilation failure, (inserting else branch in the wrong place)
Oct 3, 2019
For future reference, we need to replace to non-ascii characters in the source files as part of pre-processing because they mess up the parser range counts somehow.
What
Somehow the coverage tool inserts the
else
in wrong place and make the contract non-compilable. (It failed to insert after the{
ofif
block and inserted inside theif
)Here is one error instance on our CI: https://circleci.com/gh/omisego/plasma-contracts/3663
I make a branch for the failing code: https://github.com/boolafish/plasma-contracts/tree/solidity_coverage_bug_inserting_coverage_op_wrongly
I think the root cause is I copy pasted some weird symbol to the code comment and it start to fail. And I tried to fix with this commit: omgnetwork/plasma-contracts@c7ff3eb
It was able to work locally (to compile)
Version
The text was updated successfully, but these errors were encountered: