Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nyc support (istanbul is deprecated) #455

Open
k06a opened this issue Dec 7, 2019 · 4 comments
Open

Add nyc support (istanbul is deprecated) #455

k06a opened this issue Dec 7, 2019 · 4 comments
Labels

Comments

@k06a
Copy link

k06a commented Dec 7, 2019

Going to upgrade?

warning solidity-coverage > [email protected]: This module is no longer maintained, try this instead:
npm i nyc
Visit https://istanbul.js.org/integrations for other alternatives.

@cgewecke
Copy link
Member

cgewecke commented Dec 7, 2019

@k06a Maybe - there's kind of a big change between the istanbul and nyc output formats and the Istanbul API seems like it's worked quite well. Do you have a specific reason to prefer nyc?

I've been thinking that when I do this it will be an option.

@k06a
Copy link
Author

k06a commented Dec 7, 2019

@cgewecke I afraid istanbul may stop receiving updates, even with critical fixes.

@cgewecke
Copy link
Member

cgewecke commented Dec 7, 2019

@k06a I think that's true - it's archived. Also think it will remain stable for a long time - it does very basic stuff.

Was just looking at nyc and they don't really publish a programmatic API any more. Would probably just have to figure out how to pass the coverage.json file to the command line tool.

Have to look at the monorepo over there...

Am going to rename your issue and add it to the roadmap - thanks for opening this @k06a!

Interesting discussion about this at istanbuljs. The old API is heavily used by jest....

@cgewecke cgewecke changed the title This module is no longer maintained (istanbul) Add nyc support (istanbul is deprecated) Dec 7, 2019
@cgewecke cgewecke added the 0.7.0 label Dec 7, 2019
@cgewecke
Copy link
Member

cgewecke commented Jan 1, 2020

Small update: as an interim step, have forked istanbul and published our own copy as sc-istanbul so any dependency vulns etc can be addressed in this org if they arise. Left a few other notes about possible ways forward at #465.

This change will ship in 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants