Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinker with shadcn #935

Open
technophile-04 opened this issue Sep 15, 2024 · 2 comments
Open

tinker with shadcn #935

technophile-04 opened this issue Sep 15, 2024 · 2 comments
Assignees

Comments

@technophile-04
Copy link
Collaborator

technophile-04 commented Sep 15, 2024

Goal:

Tinker with SE-2 x ShadCn to see if it nicely integrates with our needs.

We can go with 2 routes:

  • In base SE-2 replace daisyUI with shadcn
  • we keep base SE-2 with daisyUI but allow shadcn through extensions

The rationale behind replacing daisUI with shadcn is because on surface level I think shadcn should be able to replace daisyUI in SE-2 but sometimes as we go deep into rabbit hole we hit some bad blockers that does not go with ethos of SE-2 like #444...but yeah lets tinker and see if route 1 is an option

Even if we don't go with 1st route, I think it's really good to have shadcn as core extension in create-eth

@technophile-04 technophile-04 self-assigned this Sep 15, 2024
@rin-st
Copy link
Member

rin-st commented Sep 15, 2024

Great!!

we keep base SE-2 with daisyUI but allow shadcn through extensions

I think it's not the case

  • some shadcn components conflicts with daisyui, for example sonner. I tried a week ago and it didn't work without disabling daisyui plugin
  • how should it work? We can't just replace daisyUI styles and logic inside all the core components and pages with shadcn. If not replace, everything will be the same daisyUI and just shadcnUi components will be added, so I can use them for creating my new components? I think it's not the case and no one will use it because all the app is still daisyUi
  • (less important) tailwind config with both daisy and shadcn is starting to become a mess

The rationale behind replacing daisUI with shadcn is because on surface level I think shadcn should be able to replace daisyUI in SE-2

Agree!

Btw, shadcn works fine with yarn, but their yarn copy button uses npx for yarn (looks like a bug). I used yarn dlx instead
image

@rin-st
Copy link
Member

rin-st commented Sep 15, 2024

Theme generator which can help us to generate our color https://zippystarter.com/tools/shadcn-ui-theme-generator
paste our primary color #93BBFB

But looks like we need to use it at the last steps before removing daisyui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants