Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wk.Annotation constructor should require organization name #1015

Open
fm3 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1155
Open

wk.Annotation constructor should require organization name #1015

fm3 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #1155
Assignees
@markbader
Labels
bug

Comments

@fm3
Copy link
Member

fm3 commented Mar 12, 2024

When creating a new annotation via a = wk.Annotation(name, dataset_name=dataset_name, voxel_size=voxel_size) it should be required to pass an organization name for the specified dataset to avoid ambiguity.

Otherwise during upload to wk, the lookup can be ambiguous and may fail if other organizations have datasets of that name.

Related: scalableminds/webknossos#7681
@fm3 fm3 added the bug label Mar 12, 2024
@fm3 fm3 mentioned this issue Mar 12, 2024
Closed
@hotzenklotz
Copy link
Member

I think it still would be better to infer that somehow. There are not many users which are part of multiple organisations. This would make the API more difficult for them.

The other question is: Are organizations referenced by name or ID?

@fm3
Copy link
Member Author

fm3 commented Mar 12, 2024 •
edited
Loading

I think it still would be better to infer that somehow

True, if there is an active webknossos context, the orga of the user can be used automatically.

Are organizations referenced by name or ID

This is a bit of a mess… They are referenced by name (not the display name) (the name that is also the orga directory name in the binaryData directory). However, that field is called organization_id in the libs. I once tried to adapt the webknossos side to do the same, and drop the mongoId entirely in scalableminds/webknossos#7386 but @normanrz stopped me because some external references still use the mongoId values.

Edit: we decided that we want to go ahead with this renaming after all in the coming weeks

@markbader markbader self-assigned this Jul 18, 2024
@markbader markbader linked a pull request Aug 1, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markbader markbader

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require organisation id in Annotation constructor. scalableminds/webknossos-libs
3 participants
@hotzenklotz @fm3 @markbader