Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of swagger annotations #7337

Closed
fm3 opened this issue Sep 18, 2023 · 2 comments · Fixed by #7494
Closed

Get rid of swagger annotations #7337

fm3 opened this issue Sep 18, 2023 · 2 comments · Fixed by #7494
Assignees
@fm3
Labels
backend refactoring

Comments

@fm3
Copy link
Member

fm3 commented Sep 18, 2023

the play-swagger2 lib is no longer maintained and has no releases for scala 2.13

We decided that we want to ditch swagger annotations, as they never really worked well for us anyway.

This needs significant changes to the client in webknossos-libs
@fm3
Copy link
Member Author

fm3 commented Sep 18, 2023

Is https://github.com/play-swagger/play-swagger a suitable alternative?

@fm3 fm3 mentioned this issue Nov 2, 2023
Merged
21 tasks
@fm3 fm3 self-assigned this Nov 4, 2023
@fm3
Copy link
Member Author

fm3 commented Nov 7, 2023

scalableminds/webknossos-libs#948 is now merged so we can continue on the wk side by removing the swagger code + annotations. I’d consider this blocked by #7420 in order to reduce merge conflicts and keep potentially breaking upgrades separate

@fm3 fm3 mentioned this issue Dec 11, 2023
Merged
2 tasks
@fm3 fm3 closed this as completed in #7494 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fm3 fm3

Labels
backend refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove swagger annotations, turn some into comments scalableminds/webknossos
1 participant
@fm3