Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept both JSON name and original field name when deserializing json to proto message #160

Open
jkobejs opened this issue Oct 24, 2021 · 0 comments
Open

Accept both JSON name and original field name when deserializing json to proto message #160

jkobejs opened this issue Oct 24, 2021 · 0 comments

Comments

@jkobejs
Copy link

jkobejs commented Oct 24, 2021

scalapb-json4s parser accepts both JSON name and original field name when deserializing JSON to proto message.
scalapb-circe doesn't have support for that, you can by using preservingProtoFieldNames flag pick if you want to parse using original field or JSON name, but you cannot do both.

scalapb-json4s introduced a change in this commit scalapb/scalapb-json4s@9d81da5
jkobejs added a commit to jkobejs/scalapb-circe that referenced this issue Oct 24, 2021
@jkobejs
scalapb-json#160 - accept JSON and original file names in parser
8869356
jkobejs added a commit to jkobejs/scalapb-circe that referenced this issue Oct 24, 2021
@jkobejs
\scalapb-json#160 - accept JSON and original file names in parser
005873e
jkobejs added a commit to jkobejs/scalapb-circe that referenced this issue Oct 25, 2021
@jkobejs
\scalapb-json#160 - accept JSON and original file names in parser
b955d37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkobejs