Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add block_volumes #105

Merged
merged 10 commits into from
Jan 29, 2025
Merged

feat: add block_volumes #105

merged 10 commits into from
Jan 29, 2025

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 27, 2023 •
edited
Loading

Closes #87

I didn't change root volume yet. It will probably change to sbs only as requested.

@Codelax Codelax self-assigned this Apr 27, 2023
@Codelax Codelax marked this pull request as ready for review May 2, 2023 07:49
quantumsheep
quantumsheep previously requested changes May 2, 2023
View reviewed changes
builder/scaleway/step_remove_volume.go Outdated Show resolved Hide resolved
builder/scaleway/step_server_info.go Show resolved Hide resolved
builder/scaleway/step_remove_volume.go Outdated Show resolved Hide resolved
@Codelax Codelax force-pushed the feat/block-volumes branch from 15ca325 to e408476 Compare May 2, 2023 08:57
remyleone
remyleone reviewed May 2, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@Codelax Codelax marked this pull request as draft May 2, 2023 09:43
@remyleone remyleone added the priority:highest Bugs filled by customers, security issues label May 2, 2023
@remyleone remyleone added priority:medium Improvements that are not the main priority and removed priority:highest Bugs filled by customers, security issues labels Oct 27, 2023
@Codelax Codelax force-pushed the feat/block-volumes branch from ee2186a to 9fc638f Compare January 23, 2025 13:53
@Codelax Codelax marked this pull request as ready for review January 29, 2025 09:24
@Codelax Codelax dismissed quantumsheep’s stale review January 29, 2025 09:45

no longer in team

@remyleone remyleone added this pull request to the merge queue Jan 29, 2025
Merged via the queue into scaleway:main with commit aff4e88 Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@quantumsheep quantumsheep quantumsheep left review comments

Assignees

@Codelax Codelax

Labels
blocked enhancement priority:medium Improvements that are not the main priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: block_volume
3 participants
@Codelax @remyleone @quantumsheep