Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dialogs are not hidden correctly #335

Open
schlagmichdoch opened this issue Sep 19, 2024 · 2 comments
Open

[Bug] Dialogs are not hidden correctly #335

schlagmichdoch opened this issue Sep 19, 2024 · 2 comments
Labels
accessibility bug Something isn't working UI/UX

Comments

@schlagmichdoch
Copy link
Owner

When used with a screen reader such as orca on linux in firefox or NVDA on windows the user experience is as if all the dialogs were shown at the same time.
I guess not all of them are visible on the screen but instead of hiding them with CSS they are moved off screen or masked in anyway.
Pressing tab and shift+tab reaches controls that are supposed to be hidden.
The obvious way on how to test this is that the language selector is always reachable no matter if I press its corresponding close button or not.

Originally posted by @pvagner in #306 (comment)

@schlagmichdoch schlagmichdoch added bug Something isn't working UI/UX accessibility labels Sep 19, 2024
@schlagmichdoch
Copy link
Owner Author

Apparently, the dialogs are only hidden by setting the opacity to 0. This also explains some startup issues there are with slow browsers sometimes.

@pvagner Would setting it to display: none solve this issue for screen readers like yours?

@pvagner
Copy link

pvagner commented Sep 19, 2024

@schlagmichdoch Yes, setting display: none would work for me and other screen reader users I believe. Thank you for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants