Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the ID: is this a feasible feature? #15

Open
berkes opened this issue Apr 4, 2018 · 0 comments
Open

Setting the ID: is this a feasible feature? #15

berkes opened this issue Apr 4, 2018 · 0 comments

Comments

@berkes
Copy link

berkes commented Apr 4, 2018

The documentation on KML allows and ID-attribute: e.g.<Placemark id="ID">. The comments in e.g. the placemark.rb object file, hint at this too. It is, however, not possible to set the ID, since it gets ignored.

A quick hack is a change to Placemark#render:

    def render(xm=Builder::XmlMarkup.new(:indent => 2))
      xm.Placemark(id: self.id) {
        super
        ...
      }
    end

I've some ideas on how to refactor a little to allow the ID to be set more generic, but that is quite some work, and this project seems a bit stale. Is this a feature that would be wanted?

@berkes berkes changed the title Setting the ID: is this a Setting the ID: is this a feasible feature? Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant