Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add threshold and possibly has-intercept? options to fastmath/OLS model #15

Open
behrica opened this issue May 12, 2024 · 4 comments
Open

Comments

@behrica
Copy link
Member

behrica commented May 12, 2024

No description provided.

@behrica
Copy link
Member Author

behrica commented May 12, 2024

has-intercept not yet implemented in fastmath

@behrica
Copy link
Member Author

behrica commented Jan 27, 2025

@daslu
Do you have used fastmath/OLS and looked at this question of "has-intercept" ?
Not sure, if there is something to change here

@daslu
Copy link
Member

daslu commented Jan 27, 2025

@behrica
Fastmath's lm model has an :intercept? option:
https://github.com/generateme/fastmath/blob/f5ffc6d/src/fastmath/ml/regression.clj#L291

  • :intercept? - should intercept term be included, default: true

Yes, it is useful. We use it in our tutorials:
https://scicloj.github.io/noj/noj_book.linear_regression_intro.html#prediction-by-day-of-week
https://scicloj.github.io/tablemath/tablemath_book.reference.html#examples-5

Or maybe I did not understand the question?


What do you mean by threshold?

@behrica
Copy link
Member Author

behrica commented Jan 27, 2025

I wonder if I still need to implement something.
Not sure why I created this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants