Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: please allow use system installed ninja binary #156

Closed
kloczek opened this issue Nov 5, 2022 · 3 comments
Closed

RFE: please allow use system installed ninja binary #156

kloczek opened this issue Nov 5, 2022 · 3 comments

Comments

@kloczek
Copy link

kloczek commented Nov 5, 2022

Please allow use system installed ninja binary instead bundled one.

@maxbachmann
Copy link

You can perform this check in your own build system and dynamically add this package as build dependency when it is not available on the system. I started to use this approach in my packages: https://github.com/maxbachmann/RapidFuzz/blob/main/_custom_build/backend.py.
This approach has been adopted by meson-python: mesonbuild/meson-python#175 and scikit-build: scikit-build/scikit-build-core#5 as well.

@eli-schwartz
Copy link

This is just a duplicate of #127 though. That issue has some of the background discussion that led to @henryiii implementing this for both scikit-build and meson-python.

(It would still be interesting to have a convenient way to pass a flag and build dummy metadata to satisfy projects that ended up with a forced ninja dependency. But that is a much lower priority.)

@henryiii
Copy link
Contributor

henryiii commented Dec 1, 2022

Closing as duplicate of #127.

@henryiii henryiii closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants