Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum-version checks on user-supplied parameters make packaging a real pain #912

Open
mgorny opened this issue Sep 25, 2024 · 1 comment

Comments

@mgorny
Copy link

mgorny commented Sep 25, 2024

Currently, scikit-build-core performs checks for deprecated options based on minimum-version. This is really painful for packagers who would like to use a single recipe across all packages. For example, in Gentoo we want to always use verbose builds. So we passed cmake.verbose=True — until we discovered it breaks some packages:

ERROR: Cannot set cmake.verbose if minimum-version is set to 0.10 or higher

So we switched to build.verbose=True instead. Except that now a fair number of previously working packages broke:

ERROR: Cannot set build.verbose if minimum-version is set to less than 0.10 (which is where it was introduced)

This a real pain now since we'd have to actually parse pyproject.toml in every package to determine which arguments to pass. Could you please provide weaker version checks on user-supplied options?

@henryiii
Copy link
Collaborator

We should disable these for strict-config=false (we don’t, but we should). I’d like to ignore these for config-settings and env vars, but checking where it came from could be a bit tricky.

You could set minimum-version=0.10 as a workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants