Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable testing and pushing to quay.io for CentOS7 image #399

Merged
merged 1 commit into from
Aug 15, 2023
Merged

disable testing and pushing to quay.io for CentOS7 image #399

merged 1 commit into from
Aug 15, 2023

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Aug 8, 2023 •
edited
Loading

And update Fedora images to latest base images.

This was referenced Aug 8, 2023
Closed
Closed
@zmiklank
Copy link
Contributor Author

zmiklank commented Aug 8, 2023

This PR needs rework because of demodularization of nodejs in f38.

@zmiklank zmiklank marked this pull request as draft August 9, 2023 07:10
@zmiklank
disable testing and pushing to quay.io for CentOS7 image
df68ef0 
The CentOS registry has been decommissioned[1]. Alternative registries
provide only old versions of CentOS base image. Because there is no
known possibility currently to obtain fresh CentOS7 base container image
(we do not want to update old images with yum -y update) we are stopping
rebuilds of the SCLorg's s2i-images too.  Already built images will be
still available on quay.io.

[1] https://lists.centos.org/pipermail/centos-devel/2023-May/142956.html
@zmiklank
Copy link
Contributor Author

I decided to split the PR into 2 PRs - this one now contains only changes regarding CentOS7 changes. I will create separate PR with Fedora changes as they require more work.

This PR is now ready for review.

@zmiklank zmiklank requested a review from phracek August 10, 2023 07:43
@zmiklank zmiklank marked this pull request as ready for review August 10, 2023 07:43
phracek
phracek approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@phracek
Copy link
Member

phracek commented Aug 14, 2023

[test-all]

@phracek
Copy link
Member

phracek commented Aug 14, 2023

@mhdawson The RHEL9-16 has failed on fastify

 [PASSED] for 'clients' test_client_cloudevents (00:02:04)
 [FAILED] for 'clients' test_client_fastify (00:05:01)
 [PASSED] for 'binary' test_run_binary_application (00:02:27)

@phracek
Copy link
Member

phracek commented Aug 14, 2023

The same for Fedora-18 and fastify

 [PASSED] for 'clients' test_client_cloudevents (00:01:31)
 [FAILED] for 'clients' test_client_fastify (00:03:26)
 [PASSED] for 'binary' test_run_binary_application (00:01:44)

@phracek
Copy link
Member

phracek commented Aug 15, 2023

The failure is already reported here: #391

@phracek phracek merged commit f4a832b into sclorg:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zmiklank @phracek