Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji autosuggestion buttons to the keyboard UI #138

Closed
2 tasks done
andrewtavis opened this issue Sep 21, 2024 · 5 comments
Closed
2 tasks done

Add emoji autosuggestion buttons to the keyboard UI #138

andrewtavis opened this issue Sep 21, 2024 · 5 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Something that's needed for #66 is the buttons that would be used for autosuggestions. This issue would add these in. We'd like two different sets of buttons - one with two buttons for phones and one with three buttons for tablets. Each set should span the width of the third autosuggest button, and the distance between the emoji buttons should be the distance between the autosuggest buttons.

The set of two buttons for phones should have buttons widths that are:

(WIDTH_OF_THIRD_AUTOSUGGEST_BUTTON - DISTANCE_BETWEEN_AUTOSUGGEST_BUTTONS) / 2

The set of three buttons for tablets should have buttons widths that are:

(WIDTH_OF_THIRD_AUTOSUGGEST_BUTTON - (DISTANCE_BETWEEN_AUTOSUGGEST_BUTTONS * 2)) / 3

The reason the distance between the autosuggest buttons is factored in twice for the tablet buttons is that we have three buttons and thus two spaces between them :)

For this issue we can color the buttons to show that they're present and available for use. The tablet buttons should be placed on top of the phone buttons so the phone buttons can be seen below. Both sets of buttons can be placed on top of the third autosuggestion button. We can make the tablet buttons red and the phone buttons orange for now, or just distinct colors.

Contribution

Happy to support with this and review eventually, or can also work on it myself as is needed 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Sep 21, 2024
@Linfye
Copy link
Collaborator

Linfye commented Sep 21, 2024

I'd like to work on this issue. :)

@andrewtavis
Copy link
Member Author

Thanks for your willingness to help here and take so much ownership of the emojis, @Linfye!

@Linfye
Copy link
Collaborator

Linfye commented Sep 25, 2024

I'm not quite clear where these emoji buttons should be added. Shouldn't the "third autosuggest button" be plural buttons"? Do you mean that the emoji buttons need to overlay the original buttons?

Could you please tell me more details about completing this issue? Thanks! 😊

@andrewtavis
Copy link
Member Author

Yes these buttons should overlay the plural button. Basically when we need to show emojis we hide the plural button and deactivate it, and then we show and activate the emoji buttons 😊

@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Sep 30, 2024
@andrewtavis
Copy link
Member Author

Closed by #158 🚀 Thanks so much for the hard work, @Linfye! Amazing work 😊

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants