Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the existing View Pager to Pager #256

Closed
2 tasks done
angrezichatterbox opened this issue Dec 1, 2024 · 4 comments
Closed
2 tasks done

Migrate the existing View Pager to Pager #256

angrezichatterbox opened this issue Dec 1, 2024 · 4 comments
Assignees
Labels
-priority- High priority blocked Another issue is blocking feature New feature or request good first issue Good for newcomers

Comments

@angrezichatterbox
Copy link
Member

Terms

Description

The app currently employs a View Pager, and the compose views are being set from fragments. This approach was implemented to ensure a functional main throughout the migration process of individual pages to Jetpack Compose. Once the migration is complete, we can convert the View Pager to a Compose alternative that uses the Pager layout. This issue addresses this conversion.

Note: This issue is blocked by #248, #217, which will migrate the remaining XML layouts to Jetpack Compose.

For more details on resolving this issue, refer to the documentation for Pager.

Contribution

I would love to work on this and am more than happy to help anyone solve this issue :)

@angrezichatterbox
Copy link
Member Author

This issue also concerns fixing the navigation, including the back swipe from subpages such as the Wikimedia Scribe page, Language settings page, Privacy Policy page, and Third party licenses page. Currently, the back swipe redirects to the incorrect page.

CC @andrewtavis @growabeard

@Saifuddin53
Copy link
Contributor

@andrewtavis @angrezichatterbox can I work on this after my exams are over tomorrow?

@angrezichatterbox
Copy link
Member Author

Yes it is totally fine. I would assign the issue to you. Thanks :)

@angrezichatterbox
Copy link
Member Author

Closed by #281. Thanks for your work @Saifuddin53

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority blocked Another issue is blocking feature New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants