Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move vibrate on keypress and popup on keypress to individual keyboard settings #141

Closed
2 tasks done
angrezichatterbox opened this issue Sep 22, 2024 · 10 comments · Fixed by #312
Closed
2 tasks done

Move vibrate on keypress and popup on keypress to individual keyboard settings #141

angrezichatterbox opened this issue Sep 22, 2024 · 10 comments · Fixed by #312
Assignees
@angrezichatterbox
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@angrezichatterbox
Copy link
Member

Terms

Description

The current implementation of the Vibrate on Keypress and Popup on Keypress settings is unified across all keyboards in the App settings RecyclerView container. To enhance user experience, the goal is to relocate these settings to the individual language settings, allowing for keyboard-specific configurations. This change will enable users to customize keypress feedback and popup behavior based on their preferred keyboard language, providing greater flexibility and personalization.

Screenshot 2024-09-22 at 2 05 30 PM

The options have to be added under the functionality recycler view for each keyboard setting as given above and have to be modified to change separately for each language.

Contribution

I would love to work on this and am more than willing to help anyone fix this issue :)
@angrezichatterbox angrezichatterbox added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 22, 2024
@andrewtavis andrewtavis added the hacktoberfest Included as a part of Hacktoberfest label Sep 30, 2024
@MostafaMohamed2002
Copy link
Contributor

i want to deep dive in the app to solve this issue ,
can you assist me with that and tell where to start ?

@angrezichatterbox
Copy link
Member Author

You could check out the Language settings fragment and how language-based settings are currently being changed for the double space for the period, accent characters, and emoji autosuggestions.

@andrewtavis
Copy link
Member

Assigned you given the interest, @MostafaMohamed2002 :) Let us know if you need any support!

@MostafaMohamed2002
Copy link
Contributor

I'll do my best 👌

@angrezichatterbox
Copy link
Member Author

Hey @MostafaMohamed2002 , Hope you're doing well. Just checking in to see if you are still working on the issue. Happy to help in case your facing any issues.

@andrewtavis
Copy link
Member

Hey @MostafaMohamed2002 👋 We'll unassign here for now, but by all means let us know if you'd have interest in working on this or another issue! 😊

@angrezichatterbox
Copy link
Member Author

I would work on this issue :)

@angrezichatterbox angrezichatterbox self-assigned this Feb 14, 2025
@andrewtavis
Copy link
Member

Thanks for picking this up, @angrezichatterbox! Getting this done before Data Reuse Days as I expect you have in mind would be really great 😊 Appreciate you prioritizing it!

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Feb 16, 2025 •
edited
Loading

If I am thinking right popup on keypress is the expanded key coming up in the keyboard right ? They havent been working for quite some while I suppose. The enable and disable.

@angrezichatterbox angrezichatterbox mentioned this issue Feb 16, 2025
Merged
2 tasks
@angrezichatterbox angrezichatterbox linked a pull request Feb 16, 2025 that will close this issue
Move the Vibrate on Keypress and Show Popup on keypress to Language settings #312
Merged
2 tasks
@andrewtavis
Copy link
Member

Sorry for the late reply here, @angrezichatterbox :) Had quite a PR I was working on 😊 Yes that's exactly right! I'll check the PR out soon! 🚀

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Feb 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angrezichatterbox angrezichatterbox

Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Scribe Board
Status: Done
Milestone
No milestone
3 participants
@andrewtavis @MostafaMohamed2002 @angrezichatterbox