Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve light and dark mode coloration and add background color to all tabs #51

Closed
2 tasks done
andrewtavis opened this issue Aug 3, 2024 · 6 comments
Closed
2 tasks done
Assignees
Labels
blocked Another issue is blocking design Relates to UX/UI designs help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Aug 3, 2024

Terms

Description

This issue would finalize the conversion from light to dark mode for the Scribe-Android application. In addition, it would also be nice if Scribe Blue was made the background for the remaining tabs of the application - i.e. Installation and Settings.

Contribution

@angrezichatterbox has expressed interest in handling this one 😊 Happy to review when it's all ready!

@andrewtavis andrewtavis added help wanted Extra attention is needed design Relates to UX/UI designs blocked Another issue is blocking labels Aug 3, 2024
@andrewtavis
Copy link
Member Author

Ah nice, @angrezichatterbox :) As you're on Triage rights I can assign you directly now. You should also be able to assign yourself for #43? Do you want to do one PR for that one and this one?

@angrezichatterbox
Copy link
Member

I would make a single PR for both issues. Whichever sounds better to you. I am also okay with making separate PR if that would be better for review.

@andrewtavis
Copy link
Member Author

No no, let's do a single one for both, @angrezichatterbox :) Thanks for the communication here during planning!

@angrezichatterbox
Copy link
Member

I have made a single pull request for both issues. Please tell me if there are any changes to be made. I have tried to add all the colours from the Figma Reference. and Tried to make the dark and light mode similar to Scribe-iOS

@andrewtavis
Copy link
Member Author

Thanks for this, @angrezichatterbox! Will try to review soon :)

@andrewtavis
Copy link
Member Author

Closed via #53 :) Thanks so much for this, @angrezichatterbox!

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another issue is blocking design Relates to UX/UI designs help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants