Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Privacy policy page to About tab #59

Closed
2 tasks done
angrezichatterbox opened this issue Aug 16, 2024 · 5 comments
Closed
2 tasks done

Add the Privacy policy page to About tab #59

angrezichatterbox opened this issue Aug 16, 2024 · 5 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@angrezichatterbox
Copy link
Member

Terms

Description

This issue would add the Privacy Policy page to the About tab of the Scribe-Android application. The image of the page is given below and the designs can be checked out here on Figma.

Privacy Policy - Light
  • Note: The issue is currently blocked Addition of Legal Tab to About Page #58 where we would be adding the legal tab view to the about page where there would be a section to navigate to the privacy policy and third-party license page.

Contribution

I’m happy to take on this issue and am more than willing to assist anyone else who wants to work on it. 😄

@angrezichatterbox angrezichatterbox added feature New feature or request blocked Another issue is blocking labels Aug 16, 2024
@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed and removed blocked Another issue is blocking labels Aug 16, 2024
@Linfye
Copy link
Collaborator

Linfye commented Aug 20, 2024

I can work on this. Could you tell me more details about this?

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Aug 20, 2024

Thank you very much!

The current About Page includes a Legal Tab with two options. This issue involves adding navigation from the Privacy Policy option to a new activity. The layout for this new activity is detailed in the issue description.

To solve this issue, you need to:

  • Create the new activity layout as specified in the issue description.
  • Implement navigation so that selecting the Privacy Policy option in the Legal Tab takes the user to the new activity.
  • You can achieve this by adding the new activity to the RecyclerView data in the About Activity.

A reference for a similar layout can be seen on the Wikimedia Scribe Page.

Feel free to ask any queries :)

@andrewtavis
Copy link
Member

Thanks for the offer to help, @Linfye! In addition to what @angrezichatterbox said, you can check PR #54 for the code that was added to include the Wikimedia and Scribe page in the app :) That'd be good to reference!

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Aug 23, 2024
@andrewtavis
Copy link
Member

Realized that I forgot to assign, @Linfye :) Please let us know if you have any questions here!

@andrewtavis
Copy link
Member

Closed via #72 🚀 Thanks so much for the work of getting up to speed with Scribe-Android, @Linfye! Amazing to have your contributions here as well :)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants