Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu item to trigger emoji autosuggestions #64

Closed
2 tasks done
angrezichatterbox opened this issue Aug 24, 2024 · 11 comments
Closed
2 tasks done

Menu item to trigger emoji autosuggestions #64

angrezichatterbox opened this issue Aug 24, 2024 · 11 comments
Assignees
@Linfye
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Aug 24, 2024 •
edited
Loading

Terms

Description

The issue is to create a menu item for enabling and disabling emoji suggestions. A corresponding issue would be created to implement the functionality of the emoji suggestions. The menu item should be present in the individual keyboard settings as seen in the Figma Design. Note that the default for this option should be to include the suggestions/completions. For now on change a Toast Message could be displayed.

Contribution

I’m happy to take on this issue and am more than willing to assist anyone else who wants to work on it. 😄
@angrezichatterbox angrezichatterbox added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 24, 2024
@andrewtavis andrewtavis moved this to Todo in Scribe Board Aug 24, 2024
@angrezichatterbox angrezichatterbox mentioned this issue Aug 24, 2024
Closed
2 tasks
@Linfye
Copy link
Collaborator

Linfye commented Sep 6, 2024

Can I work on this? This problem doesn't seem too complicated. I will try issue #66 after this. 😊

@andrewtavis
Copy link
Member

Sure thing, @Linfye! Let us know if you need any support!

@angrezichatterbox, where should the data files go so that people can start working on keyboard issues?

@angrezichatterbox
Copy link
Member Author

Sure thing, @Linfye! Let us know if you need any support!

@angrezichatterbox, where should the data files go so that people can start working on keyboard issues?

If it is JSON data we could have it in assets/.

@Linfye Linfye mentioned this issue Sep 6, 2024
Merged
1 task
@andrewtavis
Copy link
Member

Specifically we're talking SQLite databases, @angrezichatterbox :) So maybe something like assets/data/ENLanguageData.sqlite and the same for other languages? If that sounds good, I'd go ahead and upload them to the repo tonight 😊

@andrewtavis
Copy link
Member

Also looking at this, we need to do a lot of work to allow for #66 as the interface isn't ready 🤔 I'll make issues for this tonight, and maybe you can work on one or the new ones, @Linfye? :)

@andrewtavis
Copy link
Member

Specifically we need to hide the command bar and set up showing the command keys as well. The command keys are where the auto completions are populated, so we need to add them to the keyboard before #66 can be worked on.

@angrezichatterbox
Copy link
Member Author

angrezichatterbox commented Sep 6, 2024 •
edited
Loading

Specifically we're talking SQLite databases, @angrezichatterbox :) So maybe something like assets/data/ENLanguageData.sqlite and the same for other languages? If that sounds good, I'd go ahead and upload them to the repo tonight 😊

Yes. There also is the need to set up for the usage of the database using the Room library provided by Android which could be included in #66. or should it have a seperate issue.

@Linfye
Copy link
Collaborator

Linfye commented Sep 6, 2024 •
edited
Loading

Also looking at this, we need to do a lot of work to allow for #66 as the interface isn't ready 🤔 I'll make issues for this tonight, and maybe you can work on one or the new ones, @Linfye? :)

OK, I'll wait for them. :)

@andrewtavis
Copy link
Member

Yes. There also is the need to set up for the usage of the database using the Room library provided by Android which could be included in #66. or should it have a seperate issue.

This should be included in one of the issues prior to #66, but I'll keep this in mind when making them!

@andrewtavis
Copy link
Member

Closed by #81 🚀 Great work, @Linfye! Let's maybe work on some of the new issues from @angrezichatterbox while we're waiting for the data for the emoji autosuggestions :)

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Sep 6, 2024
@andrewtavis
Copy link
Member

And #83, of course :) :)

@andrewtavis andrewtavis mentioned this issue Sep 6, 2024
Closed
2 tasks
andrewtavis added a commit that referenced this issue Nov 16, 2024
@andrewtavis
Squashed 'app/src/main/assets/i18n/' changes from 5701774..c916c4d
8c70a6a 
c916c4d Update xcstrings and de/sv strings given new localizations
0a58b1c Merge pull request #75 from weblate/weblate-scribe-scribe-i18n
6b43bfd Translated using Weblate (Swedish)
f193e49 Translated using Weblate (German)
4f60287 Translated using Weblate (Swedish)
1422f5e Convert Korean JSON to xcstrings and Android values
718ab45 Update all xcstrings and strings files given new localizations
8c13530 Merge pull request #73 from yerimmii/ko-json
bc78915 Create ko.json
3f2a3de Minor edit to .gitignore for spacing
e40d892 Merge pull request #72 from axif0/bangla
1afc6ea Creating Bangla localization
23c56ed Merge pull request #70 from KesharwaniArpita/ArpitaContributionsMarathi
d49ed68 Create string.xml
7dc4b73 Create mr.json (Marathi)
6bc6502 Merge pull request #69 from axif0/work
933237d Update pr_maintainer_checklist.yaml
fa75400 Merge pull request #68 from OmarAI2003/MSA-internationalization
329ad53 Translate from en to ar
c81e3a1 Add Arabic translation file (ar.json) for localization support
45bce87 Merge pull request #66 from OmarAI2003/improve-android-convert-str-to-json
b774027 Minor spacing and removing permissions error
a3eeda1 Merge pull request #67 from weblate/weblate-scribe-scribe-i18n
c67255b Translated using Weblate (Spanish)
7054971 fix: add check for missing values_directory
a90a040 Error handling for file read and write operations
9295291 Use a single variable for the 'jsons' folder path and add error handling for missing 'jsons' folder.
5e85b16 Merge pull request #64 from OmarAI2003/improve-android-convert-jsons-to-strings
94482ef Added docstrings to Android string conversion functions
2a7b35b for the recently supported language: adding the 'hi' language folder generated by the script to prevent 'directory not found' errors when testing the reverse conversion (JSON to strings).
13a4849 small fix to the lang_dir
e5ca964 Refactor: Pre-load language JSON files before generating strings.xml files
f8ffe63 Use a single variable for the 'jsons' folder path and add error handling for missing 'jsons' folder.
7dbeaa1 Merge pull request #62 from OmarAI2003/improve-convert-jsons-to-xcstrings
a3e5fbf Minor edits to script spacing and comments
5fb2fc5 Merge pull request #63 from KesharwaniArpita/ArpitaContributionsHindi
fd91955 Create hi.json
9fcc0de fix: update inline comments to start with lowercase as per style guide.
8925a4b Rename variable for improved clarity
aee58c0 Add error handling for missing base language file
d41c8eb Remove automatic creation of the 'jsons' folder
d811de7 Optimize performance by pre-loading language JSON files
81da648 Refactor: Use a single variable for the 'jsons' folder path and ensure it exists.
f354bb4 Fix file handling: Use context managers to ensure safe reading and writing of files.
13d52f2 Merge pull request #58 from OmarAI2003/improve-convert-xcstrings-to-jsons
8b13ee6 Fix to en.json being written rather than en-US + minor edits
2a7e03d Merge pull request #61 from weblate/weblate-scribe-scribe-i18n
f0abf87 Translated using Weblate (French)
6c4acae Merge pull request #60 from OmarAI2003/fix-typo-in-readme.md
d30380a Revert: Move Localizable.xcstrings back to original location
46a68da moved Localizable.xcstrings again where it was as andrew told me
d426a4b Fix typo in README: Changed 'an tools' to 'tools'
0d48009  made the changes as per the feedback and added Localizable.xcstrings to 'jsons' directory
42e76dd Improve language handling and ensure directory creation
b1ccff7 Refactor: Use context manager for writing JSON files to ensure proper file handling.
5b97d83 Add JSON loading error handling in convert_xcstrings_to_jsons.py
32b8f70 Improve file handling in convert_xcstrings_to_jsons.py
7536be6 Update app menu headings to not include second word caps
c286cf2 Merge pull request #50 from weblate/weblate-scribe-scribe-i18n
3038710 Translated using Weblate (Spanish)
b80ddc7 Translated using Weblate (Spanish)
faf7ce3 Various fixes of strings and adding conjugate keys
1eb7d47 Minor update to readme headers
04574f8 Remove unused keys and fix colon spacing
8492a7a Make sure that application names are not localized
0ac6710 Merge pull request #48 from weblate/weblate-scribe-scribe-i18n
80708cb Translated using Weblate (Spanish)
dd15564 Merge pull request #47 from weblate/weblate-scribe-scribe-i18n
f05f74d Translated using Weblate (Spanish)

git-subtree-dir: app/src/main/assets/i18n
git-subtree-split: c916c4d563c2cf2ba8735494a76e97a6a1c912c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Linfye Linfye

Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewtavis @angrezichatterbox @Linfye