Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Slovak data queries #234

Closed
8 tasks done
andrewtavis opened this issue Oct 3, 2024 · 16 comments
Closed
8 tasks done

Expand Slovak data queries #234

andrewtavis opened this issue Oct 3, 2024 · 16 comments
Assignees
@shrutikamahale @Otom-obhazi
Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Oct 3, 2024 •
edited
Loading

Terms

Description

This issue would look into expanding the src/scribe_data/language_data_extraction/Slovak files with as much data as are possible from the current data on Wikidata. We can use code for getting data from other languages, and from there we can check Slovak data on Wikidata for what conjugations are available. We can then expand the query with optional selections of certain forms as is done in other SPARQL queries. The query can be tried on the Wikidata Query Service UI during development :)

Data types to include:

  • Nouns
  • Verbs
  • Adjectives
  • Adverbs
  • Prepositions
  • Emoji keywords

Contribution

Happy to support via a review and also answer any questions that come up during the work 😊
@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest labels Oct 3, 2024
@shrutikamahale
Copy link

Hi @andrewtavis I am looking forward to contributing.. can you assign this issue to me?

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 4, 2024
@andrewtavis
Copy link
Member Author

Looking forward to the contribution, @shrutikamahale! I just updated the link to the query above, btw :)

@andrewtavis andrewtavis changed the title Expand Slovak verbs query Expand Slovak data queries Oct 9, 2024
@andrewtavis
Copy link
Member Author

Just added a list of data types that we want to include to this issue :) Have marked those that are already done or have PRs open, and we can work on the others 😊 If the data type can't work, then we can move to the others and open up specific issues later :)

This was referenced Oct 10, 2024
Closed
Closed
@Otom-obhazi
Copy link
Contributor

can i be assigned this??

@andrewtavis
Copy link
Member Author

Thanks for your interest here, @Otom-obhazi! Let us know if we can do anything to assist :)

@Otom-obhazi Otom-obhazi removed their assignment Oct 14, 2024
@Otom-obhazi
Copy link
Contributor

please reassign me

@andrewtavis
Copy link
Member Author

Hi @Otom-obhazi 👋 Replying to your email here :) One thing to look into is the queries that the others have made for other languages. We're working in the src/scribe_data/language_data_extraction/Slovak directory, and let's work on a new query for Slovak adjectives. We can check a query for other languages like the Italian adjectives query. Copy that query and try it out at query.wikidata.org/, and then try the same query with Q9058, which is the Wikidata identifier for Slovak, instead of Q652, the Wikidata identifier for Italian. If all works well, you can send the query for Slovak adjectives along in the src/scribe_data/language_data_extraction/Slovak directory in an adjectives directory, so the final file will be src/scribe_data/language_data_extraction/Slovak/adjecives/query_adjectives.sparql.

Let me know if you have further questions!

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 14, 2024 via email

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 14, 2024 via email

@andrewtavis
Copy link
Member Author

You used the wrong language id in your query, @Otom-obhazi :) It needs to be Q9058, not Q1051. Can you fix that and then send along a PR?

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 15, 2024 via email

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 15, 2024 via email

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member Author

Circling back to the adjectives, @Otom-obhazi: There are a lot of forms on the adjectives that weren't returned by the query. Could you check the other adjectives queries and find one that's returning more than just the adjective, but also other forms? From there you can then edit your Slovak adjectives query to return the forms that you're seeing on the items on Wikidata. Happy to explain more if you need some help :)

@Otom-obhazi
Copy link
Contributor

Otom-obhazi commented Oct 15, 2024 via email

@andrewtavis
Copy link
Member Author

Given the current data, this issue's all closed out. Thanks all for the work here!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrutikamahale shrutikamahale

@Otom-obhazi Otom-obhazi

Labels
feature New feature or request good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Scribe Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewtavis @shrutikamahale @Otom-obhazi