Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put query end of statement period within OPTIONALs in all queries #391

Closed
2 tasks done
andrewtavis opened this issue Oct 16, 2024 · 4 comments
Closed
2 tasks done
Assignees
Labels
good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed refactor Refactor code to improve quality

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Oct 16, 2024

Terms

Issue

As of now there are many queries in Scribe-Data where the OPTIONAL selections has a period at the end of it. It would be ideal if the period was at the end of the statement within it instead in all cases. So rather than:

  OPTIONAL {
    ?lexeme ontolex:lexicalForm ?absSingularForm .
    ?absSingularForm ontolex:representation ?absSingular ;
      wikibase:grammaticalFeature wd:Q332734, wd:Q110786 ;
  } .

Rather:

  OPTIONAL {
    ?lexeme ontolex:lexicalForm ?absSingularForm .
    ?absSingularForm ontolex:representation ?absSingular ;
      wikibase:grammaticalFeature wd:Q332734, wd:Q110786 .
  }

This issue is relatively laborious, but it would be really great to get someone to pick it up and fix all of the queries 😊

@andrewtavis andrewtavis added help wanted Extra attention is needed good first issue Good for newcomers refactor Refactor code to improve quality hacktoberfest Included as a part of Hacktoberfest labels Oct 16, 2024
@kanishk128
Copy link
Contributor

Hey, I could help out with this, could it be assigned to me?

@andrewtavis
Copy link
Member Author

Sounds great, @kanishk128! Thanks for your offer to help :)

@kanishk128
Copy link
Contributor

Hey, completed it @andrewtavis! Was pretty cumbersome, skipped my dinner unknowingly. Check and revert for feedback if any

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 16, 2024
@andrewtavis
Copy link
Member Author

Closed by #393 :) Ya I can imagine, @kanishk128... Appreciate you putting in all of the effort! The point of this is actually making sure that the queries are uniform so that we can parse them for correctness automatically later. Thanks a lot! 😊

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed refactor Refactor code to improve quality
Projects
Archived in project
Development

No branches or pull requests

2 participants