Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate clean up of ExtrinsicParamsBuilder #400

Closed
haerdib opened this issue Dec 23, 2022 · 0 comments · Fixed by #405
Closed

Investigate clean up of ExtrinsicParamsBuilder #400

haerdib opened this issue Dec 23, 2022 · 0 comments · Fixed by #405
Assignees
@haerdib
Labels
F5-refactor Does not change any functionality of the code Q3-substantial

Comments

@haerdib
Copy link
Contributor

haerdib commented Dec 23, 2022 •
edited
Loading

The ExtrinsicParamsBuilder and ExtrinsicParams seem to be a bit overly complex to me. Not yet sure how to simplify it, but I think it's worth to investigate there.

Also some unit tests would be nice.

Probably linked: #357
@haerdib haerdib added F5-refactor Does not change any functionality of the code Q3-substantial labels Dec 23, 2022
@haerdib haerdib self-assigned this Dec 30, 2022
@haerdib haerdib mentioned this issue Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F5-refactor Does not change any functionality of the code Q3-substantial
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up extrinsic params builder scs/substrate-api-client
1 participant
@haerdib