fix(train): in case of last batch <=2, move to validation if possible #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining if possible
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
==========================================
- Coverage 84.96% 84.53% -0.44%
==========================================
Files 178 178
Lines 15048 15061 +13
==========================================
- Hits 12786 12732 -54
- Misses 2262 2329 +67
|
…rought the batch_size and drop_last in the data split validation
for more information, see https://pre-commit.ci
…_than1' into Ori-3035-fix_min_bathc_size_less_than1
ori-kron-wis
changed the title
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 12, 2024
canergen
reviewed
Nov 12, 2024
for more information, see https://pre-commit.ci
…_than1' into Ori-3035-fix_min_bathc_size_less_than1
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
canergen
reviewed
Nov 14, 2024
…c_size_less_than1
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that train_size is None and the size of the last batch during training is <=2 , we adaptively move those samples from training to validation if possible. If train_size is set by user we do no fix this error and let the user change its train_size, selected indices or use drop last batch option.
close #3035