Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be smarter about parsing output for tally #48

Open
seblyng opened this issue Dec 14, 2022 · 1 comment
Open

Be smarter about parsing output for tally #48

seblyng opened this issue Dec 14, 2022 · 1 comment

Comments

@seblyng
Copy link
Owner

seblyng commented Dec 14, 2022

Currently, the way we recognises if a day is implemented or not is if we find the output from the time function in the template.

This will fail if anything else is printed to stdout as we assumes it's the first and second line of the output.

I think we can be smarter about this and still recognise the days as implemented even if there is some other prints here and there in the output

@sivertjoe
Copy link
Collaborator

Yeah, I thought about checking the exit code, but I must have forgotten. Anyways yeah you're right, just check the exit code of the day to test whether its implemented or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants