Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@neodx/log Generalize and unify colors settings and defaults #133

Open
secundant opened this issue Jan 21, 2024 · 0 comments
Open

@neodx/log Generalize and unify colors settings and defaults #133

secundant opened this issue Jan 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working scope:log Issues related to logger

Comments

@secundant
Copy link
Owner

Under this issue, I want to fix the inconsistent and incorrect (@neodx/log/http doesn't disable colors in production) default behavior of "colors" and simplify its management from the outside.

Where are colors being used now?

  • @neodx/log/node
    • pretty target and default behavior
    • printPrettyError submodule (extends from pretty)
  • @neodx/log/http

Expectations:

  • Everything should follow the same default rule - colors are disabled in production.
  • Simplify the colors parameter to accept values of 'auto', boolean, or Colors.

Good to try:

  • Enhance the createLogger API in @neodx/log/node to be more high-level, forward the colors parameter to global settings.
@secundant secundant added bug Something isn't working scope:log Issues related to logger labels Jan 21, 2024
@secundant secundant self-assigned this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:log Issues related to logger
Projects
None yet
Development

No branches or pull requests

1 participant