Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furthor Refactorings DD Client Lib #121

Open
Weltraumschaf opened this issue Feb 16, 2024 · 0 comments · May be fixed by #123
Open

Furthor Refactorings DD Client Lib #121

Weltraumschaf opened this issue Feb 16, 2024 · 0 comments · May be fixed by #123
Assignees
@Weltraumschaf

Comments

@Weltraumschaf
Copy link
Member

No description provided.

@Weltraumschaf Weltraumschaf self-assigned this Feb 16, 2024
@Weltraumschaf Weltraumschaf converted this from a draft issue Feb 16, 2024
@Weltraumschaf Weltraumschaf changed the title Furthor Refactorings DD Cliient Lib Furthor Refactorings DD Client Lib Feb 16, 2024
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Reformatting
82ad1b0 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Add PRevious Reformatting Commit to Blame Ignore
1f2137a 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Add Lombok to Compiler's Annotation Processors
da6b041 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 USe Logging Facade Instead of System.out
3d76d32 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 The Readme Referenced Old Class Name
9d4be9d 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Remove Unused Imports
b941ab8 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 Reformatting
c560d53 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 Add PRevious Reformatting Commit to Blame Ignore
3676ec6 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 Add Lombok to Compiler's Annotation Processors
ea2ff5e 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 USe Logging Facade Instead of System.out
a1e820e 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 The Readme Referenced Old Class Name
c626446 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit that referenced this issue Feb 16, 2024
@Weltraumschaf
#121 Remove Unused Imports
8996df9 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Introduce Our Own Exception Type Hierarchy
7a5af86 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Remove Checked Exception to Provide a Cleaner API
a61cc13 
Checked exceptions in a public used API is quite cumbersome. Alo
checked exceptions should onlybe used forerrors you can deal with
in the source code. Since the errors in this case origin from outside,
it is better to use runtime exceptions. This does not clutter the API
clients.

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Use Latest Version 17 of Java
99715e7 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Javadoc Tool Can't Lookup Lombok Generated Stuff
161a9fa 
Signed-off-by: Sven Strittmatter <[email protected]>
@Weltraumschaf Weltraumschaf linked a pull request Feb 16, 2024 that will close this issue
Draft
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Remove Checked Exception to Provide a Cleaner API
4d0c5fe 
Checked exceptions in a public used API is quite cumbersome. Alo
checked exceptions should onlybe used forerrors you can deal with
in the source code. Since the errors in this case origin from outside,
it is better to use runtime exceptions. This does not clutter the API
clients.

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Use Latest Version 17 of Java
d5183c5 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Javadoc Tool Can't Lookup Lombok Generated Stuff
601d6ce 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Extract Auth Header Facotry from Intermediate Class
574cf01 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Extract Proxy Credential Facotry from Intermediate …
2f23058 
…Class

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Log in Debug Level Which Auth Headers are Set
67a4cb7 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Feb 16, 2024
@Weltraumschaf
secureCodeBox#121 Remove Unused field from Intermediate Class
f8efcca 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Mar 5, 2024
@Weltraumschaf
secureCodeBox#121 Introduce Our Own Exception Type Hierarchy
59bbda4 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Mar 5, 2024
@Weltraumschaf
secureCodeBox#121 Remove Checked Exception to Provide a Cleaner API
492bdf9 
Checked exceptions in a public used API is quite cumbersome. Alo
checked exceptions should onlybe used forerrors you can deal with
in the source code. Since the errors in this case origin from outside,
it is better to use runtime exceptions. This does not clutter the API
clients.

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Javadoc Tool Can't Lookup Lombok Generated Stuff
a662260 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Extract Auth Header Facotry from Intermediate Class
f1cc201 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Extract Proxy Credential Facotry from Intermediate …
8804bf1 
…Class

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Log in Debug Level Which Auth Headers are Set
814d455 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Remove Unused field from Intermediate Class
f5ff0ae 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Give Config a Better Name to Make it More Distingui…
7c192c0 
…shable from ProxyConfig

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Log proxi configuration
78f330a 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Do not Create Unecessary Objects
29ba64d 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Use Better Variable Name
4f2ee00 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Extract Method to Generate Base URL
e5368d6 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Mark Dedicated Constructor
f439576 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Make Vars Final
e9ad077 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Add Bug Marker
28c7c4b 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Add Missing JavaDoc
eb975b1 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Use URI Instead of String
3309da3 
This has theadvantage that URLs are validated in place and we can
normalize theresulting URL to remove double slashes from path.

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Reformat Lambdas for Readability
a537644 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Remove Obsolete Checked Exceptions from Method Sign…
1ce7c07 
…ature

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Move Overloaded Method Before the Implemented
08f98cc 
Follow the principle of more details towards the bottom of file.

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Add Tests to Verify Presence of Auth Token in Headers
34abd4c 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Hide Client Config Because Only USed in This Class
b67f8c5 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Hide Rest Template Because Only USed in This Class
307747c 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Extract Proxy Config As Field to Make it Injectable…
e00225a 
… in Tests

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Give Method Better Name Since it is Not a Simple Ge…
9fb2b5e 
…tter

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Add Tests to Verify Presence of Proxy Auth Header
d72ee2f 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Remove Uneccessary Indirect Call to REST Template
9797207 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Reduce Coupling to Jackso by Extracting Mappers int…
190dfc7 
…o Own Object

Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Remove Uneccessary This Qualifier
e4c7afd 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Give Class a More Meaningful Name
51c3122 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Do Not Create Proxy Config Twice
2d58c31 
Signed-off-by: Sven Strittmatter <[email protected]>
Weltraumschaf added a commit to Weltraumschaf/defectdojo-client-java that referenced this issue Jul 3, 2024
@Weltraumschaf
secureCodeBox#121 Extract Request Entity Creation
4f67514 
Signed-off-by: Sven Strittmatter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Weltraumschaf Weltraumschaf

Labels
None yet
Projects
secureCodeBox v4
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Furhtor Refactroing Weltraumschaf/defectdojo-client-java
1 participant
@Weltraumschaf