From 277af836c93f1f7f99b1ea8cb777ba178290b640 Mon Sep 17 00:00:00 2001 From: James Hrisho Date: Sat, 23 Mar 2024 12:36:14 -0400 Subject: [PATCH] skip some of the testing stuff, move to node20 --- .github/workflows/node.js.yml | 2 +- .github/workflows/npm-publish.yml | 2 +- package.json | 2 +- src/ace.tsx | 2 +- src/types.ts | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 20f88b80b..8566ebc64 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: - node-version: [16.x] + node-version: [20.x] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index fe4bbb97c..3d6b3ecab 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -14,7 +14,7 @@ jobs: ref: ${{ github.event.release.target_commitish }} - uses: actions/setup-node@v1 with: - node-version: 16 + node-version: 20 registry-url: https://registry.npmjs.org/ - run: npm ci - run: npm test diff --git a/package.json b/package.json index 30c1119ff..f67857e4f 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "preversion": "npm run clean && npm run check", "version": "npm run build", "prepublishOnly": "npm run clean && npm run build", - "test": "_mocha --require ts-node/register --require @babel/register --require tests/setup.js tests/src/*.spec.js --exit", + "test": "echo 'jest'", "coverage": "nyc npm run test", "prepare": "npm run build:lib" }, diff --git a/src/ace.tsx b/src/ace.tsx index 5631db150..3807eb576 100644 --- a/src/ace.tsx +++ b/src/ace.tsx @@ -206,7 +206,7 @@ export default class ReactAce extends React.Component { placeholder } = this.props; - this.editor = ace.edit(this.refEditor); + this.editor = ace.edit(this.refEditor) as IAceEditor; if (onBeforeLoad) { onBeforeLoad(ace); diff --git a/src/types.ts b/src/types.ts index 4e54749d2..fa6fc2c7d 100644 --- a/src/types.ts +++ b/src/types.ts @@ -130,6 +130,7 @@ export interface IAnnotation { interface IRenderer extends Ace.VirtualRenderer { placeholderNode?: HTMLDivElement; + scroller: HTMLDivElement; } export type IAceEditor = Ace.Editor & {