Sample links to registered files are not displaying the the Datafile samples table view

[AndrewWood94]

When extracting Samples which include a 'Registered Data File' attribute, the link to the associated datafile works when viewing the confirm extraction table (e.g. column 'ImageFile' here).

However, once the file has been extracted, the Datafile samples table displays [object Object] instead of the linked datafile
(example here)

[stuzart]

thanks @AndrewWood94 . I think this a UI issue and case of it not being updated as the features have evolved.

The button to view samples was originally added just to show extracted samples, before there was the ability to link data files through a sample attribute. Since this was added, the related_samples has been updated, and does include the linked samples as well as the extracted ones, but clicking the link to view all takes you to data_files/n/samples which just displays the extracted ones.

I think it needs updating so that the button is clearer that it is to show only the extracted samples, with its own route, but then data_files/n/samples should show the usual filtered view and include all related samples.

[AndrewWood94]

Is it possible to have samples related to a datafile which are not extracted from the datafile?
If not, I think it would be good for the ISA graph to link to extracted samples rather than related samples, so users can see the sample data, not just metadata

[stuzart]

yes, it is possible to have other samples related to a data file. Those that have been linked through the Registered DataFile sample attribute. So, data_file.related_samples can contain a mixture of those extracted and others that are linked through this attribute.

[stuzart]

As mentioned on wednesday, fixing this raised some other issues so there is an issue for future improvements #2055 . But closing this as the underlying problem reported has been fixed.