Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save profile names capitalized at sign-in, mentee, and mentor applications #160

Closed
4 tasks
Madhawa97 opened this issue Aug 25, 2024 · 6 comments · Fixed by #167
Closed
4 tasks

Save profile names capitalized at sign-in, mentee, and mentor applications #160

Madhawa97 opened this issue Aug 25, 2024 · 6 comments · Fixed by #167
Assignees
Labels
backend A backend task good first issue Good for newcomers priority: medium Medium priority task

Comments

@Madhawa97
Copy link
Member

Madhawa97 commented Aug 25, 2024

Description:
Ensure profile names are saved with the first letter of each word capitalized during sign-in, mentee, and mentor applications.

Tasks:

  • Capitalize profile names before saving during sign-in.
  • Capitalize profile names before saving during mentee application.
  • Capitalize profile names before saving during mentor application.
  • Update relevant documentation.

Acceptance Criteria:

  • Profile names are saved with the first letter of each word capitalized.
  • Unit tests confirm proper capitalization.
  • No negative impact on existing workflows.

Additional Information:

Related Dependencies or References:

@Madhawa97 Madhawa97 added good first issue Good for newcomers backend A backend task priority: medium Medium priority task labels Aug 31, 2024
@Disura-Randunu
Copy link
Contributor

Hey @anjula-sack. Shall I work on this issue?

@Madhawa97
Copy link
Member Author

Sure go ahead! @Disura-Randunu

@Disura-Randunu
Copy link
Contributor

Disura-Randunu commented Sep 15, 2024

@Madhawa97, @anjula-sack Where can I find the documentation that needs to be updated?

@Disura-Randunu
Copy link
Contributor

Disura-Randunu commented Sep 15, 2024

Unit test for registration is failing because "profile" is null.
But it's working as expected when the request is executed. (Profile returns in the body)

auth.service.ts : 44 - 48

    await profileRepository.save(newProfile)

    const savedProfile = await profileRepository.findOne({
      where: { primary_email: email }
    })

Might be becuase it takes some time for the DB to commit and "savedProfile" is empty at that time. Shall I change it as below?

const savedProfile = await profileRepository.save(newProfile)

@anjula-sack
Copy link
Member

@Disura-Randunu Can you send the PR, then let's see what's happening based on your changes

@Disura-Randunu
Copy link
Contributor

@anjula-sack added PR: #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend A backend task good first issue Good for newcomers priority: medium Medium priority task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants