From b8bd97dc90e6b7a3c9975fe8795c5426a16114c8 Mon Sep 17 00:00:00 2001 From: kbhat1 Date: Tue, 9 Apr 2024 18:48:10 -0400 Subject: [PATCH] Check err before defer --- storev2/rootmulti/store.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storev2/rootmulti/store.go b/storev2/rootmulti/store.go index e80670c28..be93a041d 100644 --- a/storev2/rootmulti/store.go +++ b/storev2/rootmulti/store.go @@ -507,10 +507,10 @@ func (rs *Store) Query(req abci.RequestQuery) abci.ResponseQuery { } else { // Serve abci query from historical sc store if proofs needed scStore, err := rs.scStore.LoadVersion(version, true) - defer scStore.Close() if err != nil { return sdkerrors.QueryResult(err) } + defer scStore.Close() store = types.Queryable(commitment.NewStore(scStore.GetTreeByName(storeName), rs.logger)) commitInfo = convertCommitInfo(scStore.LastCommitInfo()) commitInfo = amendCommitInfo(commitInfo, rs.storesParams)