Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Fix for a Known Nil Pointer Issue #253

Open
Hellobloc opened this issue Dec 29, 2024 · 0 comments
Open

Missing Fix for a Known Nil Pointer Issue #253

Hellobloc opened this issue Dec 29, 2024 · 0 comments

Comments

@Hellobloc
Copy link

The code is missing a fix for the Comebft vulnerability because, in certain situations, receiving a malicious vote message can cause a malicious index to exceed the limit, leading to a null pointer panic.

if err := vote.VerifyExtension(cs.state.ChainID, val.PubKey); err != nil {

Ref

https://github.com/cometbft/cometbft/pull/4441/files#diff-51109119207cf15f4491c8288086704e22a037357ad6ebc68a3b24b4818904fdL2194

cometbft/cometbft#4441

GHSA-p7mv-53f2-4cwj

@Hellobloc Hellobloc changed the title Missing Fix for GHSA-p7mv-53f2-4cwj Missing Fix for a Known Nil Pointer Issue Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant