Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'retry' should mark child runs that weren't yet terminal as failed/canceled #1119

Open
augray opened this issue Apr 15, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@augray
Copy link
Member

augray commented Apr 15, 2024

When a retry happens where one run is the parent of other runs, the child runs should be stopped if they were not already in a terminal state. If the retry was triggered by a failure in one of these child runs, and there was no parallelism, this will have happened naturally. However, there are two cases where a retry can be triggered where there are still active child runs:

(a) if there is parallelism in the child runs, and only one of the branches failed (other branches would still be active)
(b) if the parent had a timeout, and therefore the parent fails despite the children being otherwise healthy.

@augray augray added the bug Something isn't working label Apr 15, 2024
@augray augray changed the title 'retry' should mark child runs that weren't yet terminal as failed 'retry' should mark child runs that weren't yet terminal as failed/canceled Apr 15, 2024
@augray
Copy link
Member Author

augray commented Apr 15, 2024

This will be kind of tricky to do: currently there is an assumption that if there are any failed/canceled runs in the pipeline, the whole pipeline should be failed. Fixing this bug would mean changing that assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant