Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-ify pre-commit #198

Closed
augray opened this issue Oct 10, 2022 · 1 comment
Closed

bazel-ify pre-commit #198

augray opened this issue Oct 10, 2022 · 1 comment
Labels
ci Continuous Integration infrastructure housekeeping Things that won't impact users, but will impact project devs

Comments

@augray
Copy link
Member

augray commented Oct 10, 2022

Right now you have to have a virtual environment set up to run black/pylint/isort. It would be much better if there was a bazel command you could execute for this. This would make it easier for folks to contribute to open-source. We should also, in general, look at things in our Makefiles to see if we can bazelify them (if you do that, please file new "housekeeping" tickets)
@augray augray added the housekeeping Things that won't impact users, but will impact project devs label Oct 10, 2022
@tscurtu tscurtu added ci Continuous Integration infrastructure usability and removed housekeeping Things that won't impact users, but will impact project devs labels Jul 20, 2023
@tscurtu tscurtu added housekeeping Things that won't impact users, but will impact project devs and removed usability labels Nov 13, 2023
@augray
Copy link
Member Author

augray commented Jan 8, 2025

obsolete as of #1145

@augray augray closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous Integration infrastructure housekeeping Things that won't impact users, but will impact project devs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tscurtu @augray