Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pr template #349

Merged
merged 3 commits into from
Aug 23, 2024
Merged

chore: add pr template #349

merged 3 commits into from
Aug 23, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Aug 22, 2024

Changes

  • Added Pull Request template

ticket:

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@bang9 bang9 self-assigned this Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 8756c19
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66c82d63451c390008c4bb4a
😎 Deploy Preview https://deploy-preview-349--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 22, 2024

Size Change: 0 B

Total Size: 616 kB

ℹ️ View Unchanged
Filename Size
./dist/__bundle-46d64517-********.js 4.01 kB
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/__bundle-91b5ecea-********.js 890 B
./dist/index-********.js 314 kB
./dist/index.es.js 170 B
./dist/index.umd.js 290 kB
./dist/style.css 7.93 kB

compressed-size-action

@bang9 bang9 added the 1.7.9 label Aug 22, 2024
@bang9 bang9 requested a review from liamcho August 22, 2024 06:01
@bang9 bang9 removed the 1.7.9 label Aug 22, 2024
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add ticket info?

Fixes [](https://sendbird.atlassian.net/browse/)

@bang9
Copy link
Contributor Author

bang9 commented Aug 23, 2024

Can you add ticket info?

Fixes [](https://sendbird.atlassian.net/browse/)

The ticket might be a feature rather than a bug, so I simply referred to it as 'ticket:'
If you enter the ticket ID in the format [AC-XXXX], it will automatically be converted into a link.

@bang9 bang9 merged commit 292e3ec into develop Aug 23, 2024
10 checks passed
@bang9 bang9 deleted the chore/pr-template branch August 23, 2024 06:36
liamcho pushed a commit that referenced this pull request Aug 29, 2024
## Changes
- Added Pull Request template

ticket:

## Additional Notes
- 

## Checklist
Before requesting a code review, please check the following:
- [x] **[Required]** CI has passed all checks.
- [x] **[Required]** A self-review has been conducted to ensure there
are no minor mistakes.
- [x] **[Required]** Unnecessary comments/debugging code have been
removed.
- [x] **[Required]** All requirements specified in the ticket have been
accurately implemented.
- [ ] Ensure the ticket has been updated with the sprint, status, and
story points.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants