Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA for modularization phase 1 #353

Merged
merged 12 commits into from
Sep 6, 2024
Merged

QA for modularization phase 1 #353

merged 12 commits into from
Sep 6, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Aug 27, 2024

Changes

ticket: AC-3645

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/66d7acc0e19000f69560efd4
😎 Deploy Preview https://deploy-preview-353--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bang9 bang9 changed the base branch from develop to feat/module1/base August 27, 2024 02:36
Copy link

github-actions bot commented Aug 27, 2024

Size Change: +10 B (0%)

Total Size: 593 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB +4 B (+0.1%)
./dist/__bundle-91b5ecea-********.js 893 B +2 B (+0.22%)
./dist/index-********.js 301 kB -22 B (-0.01%)
./dist/index.es.js 173 B +2 B (+1.17%)
./dist/index.umd.js 278 kB +14 B (+0.01%)
./dist/Placeholder.error-********.js 346 B -1 B (-0.29%)
./dist/Placeholder.loading-********.js 346 B +2 B (+0.58%)
./dist/Placeholder.noChannels-********.js 183 B -1 B (-0.54%)
./dist/Placeholder.noMessages-********.js 183 B -1 B (-0.54%)
./dist/PlaceholderCommon-********.js 248 B +2 B (+0.81%)
./dist/style.css 8.07 kB +9 B (+0.11%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B

compressed-size-action

@bang9 bang9 force-pushed the feat/module1/qa branch 2 times, most recently from d1e2d3b to a462e4a Compare August 29, 2024 03:46
@bang9 bang9 marked this pull request as draft August 29, 2024 04:59
@bang9 bang9 self-assigned this Aug 29, 2024
@bang9 bang9 force-pushed the feat/module1/base branch from 02f62c8 to c9e1e27 Compare August 29, 2024 05:06
@bang9 bang9 requested a review from liamcho September 2, 2024 07:53
@bang9 bang9 marked this pull request as ready for review September 2, 2024 07:53
Copy link
Contributor

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit 1411e8c into feat/module1/base Sep 6, 2024
6 checks passed
@bang9 bang9 deleted the feat/module1/qa branch September 6, 2024 00:08
bang9 added a commit that referenced this pull request Sep 6, 2024
-

ticket: [AC-3645]

-

Before requesting a code review, please check the following:
- [x] **[Required]** CI has passed all checks.
- [x] **[Required]** A self-review has been conducted to ensure there
are no minor mistakes.
- [x] **[Required]** Unnecessary comments/debugging code have been
removed.
- [x] **[Required]** All requirements specified in the ticket have been
accurately implemented.
- [x] Ensure the ticket has been updated with the sprint, status, and
story points.

[AC-3645]:
https://sendbird.atlassian.net/browse/AC-3645?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@bang9 bang9 added the 1.8.0 label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants