-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA for modularization phase 1 #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chat-ai-widget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +10 B (0%) Total Size: 593 kB
ℹ️ View Unchanged
|
bang9
force-pushed
the
feat/module1/qa
branch
2 times, most recently
from
August 29, 2024 03:46
d1e2d3b
to
a462e4a
Compare
bang9
force-pushed
the
feat/module1/base
branch
from
August 29, 2024 05:06
02f62c8
to
c9e1e27
Compare
bang9
force-pushed
the
feat/module1/qa
branch
from
September 2, 2024 01:28
a6e49dd
to
1c0f54e
Compare
bang9
force-pushed
the
feat/module1/qa
branch
from
September 2, 2024 07:55
a6bbf70
to
0c562a7
Compare
liamcho
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bang9
added a commit
that referenced
this pull request
Sep 6, 2024
- ticket: [AC-3645] - Before requesting a code review, please check the following: - [x] **[Required]** CI has passed all checks. - [x] **[Required]** A self-review has been conducted to ensure there are no minor mistakes. - [x] **[Required]** Unnecessary comments/debugging code have been removed. - [x] **[Required]** All requirements specified in the ticket have been accurately implemented. - [x] Ensure the ticket has been updated with the sprint, status, and story points. [AC-3645]: https://sendbird.atlassian.net/browse/AC-3645?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ticket: AC-3645
Additional Notes
Checklist
Before requesting a code review, please check the following: