Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unit tests #407

Closed
wants to merge 1 commit into from
Closed

test: Unit tests #407

wants to merge 1 commit into from

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Dec 19, 2024

Changes

ticket: AC-4551

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho requested a review from bang9 December 19, 2024 07:21
@liamcho liamcho self-assigned this Dec 19, 2024
@liamcho liamcho marked this pull request as draft December 19, 2024 07:21
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit cafdd44
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/6763c9633d1a0800085f642e
😎 Deploy Preview https://deploy-preview-407--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liamcho
Copy link
Contributor Author

liamcho commented Dec 19, 2024

@bang9 실행하면 에러가 나는데 어떤 설정이 필요한걸까요?

➜  chat-ai-widget git:(test/AC-4551-add-unit-tests) ✗ yarn test-ct
Error: /Users/liam.cho/Github/chat-ai-widget/__visual_unit_tests__/tests.spec.tsx: Couldn't find a Program

    at e.getProgramParent (/Users/liam.cho/Github/chat-ai-widget/node_modules/playwright/lib/transform/babelBundleImpl.js:12:40826)

edit:
원인을 찾았습니다. 아래 두개가 충돌이 있는것 같습니다

    "@playwright/experimental-ct-react": "^1.49.1",
    "@playwright/test": "^1.48.1",

@playwright/test 를 지우고 install 하면 잘 돕니다. 그래서 둘중 하나는 포기해야만 하는 상황인것 같습니다. 현재는 @playwright/test 로 e2e 테스트를 돌리고 있기 때문에 unit test 를 포기해야 할 것 같습니다..

Copy link

Size Change: 0 B

Total Size: 618 kB

ℹ️ View Unchanged
Filename Size
./dist/__bundle-46d64517-********.js 4.01 kB
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/__bundle-b5ef7de4-********.js 890 B
./dist/index-********.js 304 kB
./dist/index.es.js 171 B
./dist/index.umd.js 289 kB
./dist/Placeholder.error-********.js 346 B
./dist/Placeholder.loading-********.js 183 B
./dist/Placeholder.noChannels-********.js 182 B
./dist/Placeholder.noMessages-********.js 183 B
./dist/PlaceholderCommon-********.js 244 B
./dist/style.css 9.52 kB
./dist/TokensBody-********.js 9.1 kB

compressed-size-action

@liamcho
Copy link
Contributor Author

liamcho commented Jan 8, 2025

see comment above

@liamcho liamcho closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant