Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update useStyledComponentsTarget to support case where head tag is removed. #414

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jan 22, 2025

Changes

  • Re-fixed an issue where widget style is not applied due to style tag being dynamically removed and then re-added in the head tag in a WordPress like environment

ticket: AA-772

Additional Notes

Checklist

Before requesting a code review, please check the following:

  • [Required] CI has passed all checks.
  • [Required] A self-review has been conducted to ensure there are no minor mistakes.
  • [Required] Unnecessary comments/debugging code have been removed.
  • [Required] All requirements specified in the ticket have been accurately implemented.
  • Ensure the ticket has been updated with the sprint, status, and story points.

@liamcho liamcho added the 1.9.6 label Jan 22, 2025
@liamcho liamcho requested review from AhyoungRyu and bang9 January 22, 2025 03:03
@liamcho liamcho self-assigned this Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for chat-ai-widget ready!

Name Link
🔨 Latest commit 9d27c0a
🔍 Latest deploy log https://app.netlify.com/sites/chat-ai-widget/deploys/6792f8fbad118600082d031c
😎 Deploy Preview https://deploy-preview-414--chat-ai-widget.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 22, 2025

Size Change: +244 B (+0.04%)

Total Size: 618 kB

Filename Size Change
./dist/__bundle-46d64517-********.js 4.01 kB -1 B (-0.02%)
./dist/__bundle-b5ef7de4-********.js 889 B -1 B (-0.11%)
./dist/index-********.js 304 kB +124 B (+0.04%)
./dist/index.es.js 171 B -2 B (-1.16%)
./dist/index.umd.js 289 kB +121 B (+0.04%)
./dist/Placeholder.error-********.js 345 B +1 B (+0.29%)
./dist/Placeholder.loading-********.js 184 B -1 B (-0.54%)
./dist/Placeholder.noChannels-********.js 184 B +2 B (+1.1%)
./dist/Placeholder.noMessages-********.js 184 B +1 B (+0.55%)
ℹ️ View Unchanged
Filename Size
./dist/__bundle-7c3d40f4-********.js 21 B
./dist/PlaceholderCommon-********.js 245 B
./dist/style.css 9.52 kB
./dist/TokensBody-********.js 9.1 kB

compressed-size-action

Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@liamcho
Copy link
Contributor Author

liamcho commented Jan 23, 2025

@bang9 changelog 는 1.9.4 에 나간 그데로 적어놓긴 했는데, 다른 좋은 아이디어 있으실까요?

@bang9
Copy link
Contributor

bang9 commented Jan 24, 2025

@bang9 changelog 는 1.9.4 에 나간 그데로 적어놓긴 했는데, 다른 좋은 아이디어 있으실까요?

그대로 나가도 괜찮을 것 같습니다!

@liamcho liamcho requested a review from bang9 January 24, 2025 02:21
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@liamcho liamcho merged commit 680f72f into develop Jan 24, 2025
12 checks passed
@liamcho liamcho deleted the fix/AA-772-update-useStyledComponentsTarget-to-support-case-where-head-tag-is-completely-removed-2 branch January 24, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants