From e48b372750858254ef2809ce4453e9dabf79cd33 Mon Sep 17 00:00:00 2001 From: Steven Maude Date: Wed, 18 Mar 2015 11:32:36 +0000 Subject: [PATCH] Only log response text if needed Fixes #16. This can result in `chardet` being used even if the debug statement isn't required which can be very slow on large responses (e.g. PDFs). --- dshelpers.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dshelpers.py b/dshelpers.py index c97d0ca..616949a 100644 --- a/dshelpers.py +++ b/dshelpers.py @@ -143,8 +143,9 @@ def _download_without_backoff(url, as_file=True, **kwargs): kwargs_copy['headers'] = CaseInsensitiveDict({'user-agent': _USER_AGENT}) response = requests.get(url, **kwargs_copy) - - L.debug('"{}"'.format(response.text)) + + if logging.getLogger().isEnabledFor(logging.DEBUG): + L.debug('"{}"'.format(response.text)) response.raise_for_status()