Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product_retrieval Doesn't Have http.client Spans as Children #135

Open
sdzhong opened this issue Apr 17, 2024 · 2 comments
Open

product_retrieval Doesn't Have http.client Spans as Children #135

sdzhong opened this issue Apr 17, 2024 · 2 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@sdzhong
Copy link
Contributor

sdzhong commented Apr 17, 2024

Span hierarchy of product_retrieval changed from having http.client spans as children--now they are not.

Expected behavior: The http.client spans should be product_retrieval children spans, like it was in 2.10.3 and 2.10.4:
image
image

Observed behavior: The http.client spans are not nested as product_retrieval children spans in 2.10.5:
image

@sdzhong sdzhong added the bug Something isn't working label Apr 17, 2024
@sdzhong sdzhong moved this from Todo to Eng In Progress in [Android] SE <> Eng Demo Apr 23, 2024
@stefanosiano
Copy link
Collaborator

Android SDK v7+ now binds the http spans directly to the transaction, and not to the current span anymore.
Changing this behaviour is not that simple, so i'd like to discuss how to proceed here

@sdzhong sdzhong added wontfix This will not be worked on and removed bug Something isn't working labels May 21, 2024
@sdzhong sdzhong moved this from Eng In Progress to Todo in [Android] SE <> Eng Demo May 21, 2024
@sdzhong
Copy link
Contributor Author

sdzhong commented May 21, 2024

@stefanosiano , is there anything we can do on the code-level to match the nesting we had in 2.10.3?

@sdzhong sdzhong moved this from Todo to Done in [Android] SE <> Eng Demo Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Development

No branches or pull requests

2 participants