Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise current models #49

Open
10 of 12 tasks
LimpidCrypto opened this issue Jan 27, 2023 · 0 comments
Open
10 of 12 tasks

Revise current models #49

LimpidCrypto opened this issue Jan 27, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@LimpidCrypto
Copy link
Collaborator

LimpidCrypto commented Jan 27, 2023

There are some improvements need to be done to the current models for transactions and requests:

  • utilize Default, PartialEq, Eq, Clone traits
  • split up Currency into Currency and Amount
    • Currency::Xrp must have fiel name currency
  • add tests for serializing and deserializing models
    • add macro to serialize and deserialize a struct with its tag (e.g. {"StructName": {"foo": 0, "bar": 1}})
  • change impl lifetimes
  • cleanup models/mod.rs (e.g StreamParameter should be in requests/subscribe.rs)
  • add non-common-fields documentation
  • look over request_fields.rs and move to models/requests
  • Add signing request methods with feature flag
  • Add ˋnewˋ methods to all models
    • change tests to use new
@LimpidCrypto LimpidCrypto converted this from a draft issue Jan 27, 2023
@LimpidCrypto LimpidCrypto self-assigned this Jan 27, 2023
@LimpidCrypto LimpidCrypto added the enhancement New feature or request label Jan 27, 2023
@LimpidCrypto LimpidCrypto added this to the Add models milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant