Compile definitions not exported through cmake

[oysstu]

septentrio_gnss_driver/CMakeLists.txt

Line 36 in 5e31b44

add_compile_definitions(ROS1)

septentrio_gnss_driver/CMakeLists.txt

Line 146 in 5e31b44

add_compile_definitions(ROS2)

septentrio_gnss_driver/CMakeLists.txt

Line 255 in 5e31b44

add_compile_definitions(ROS2_VER_N250)

If you instead use target_compile_definitions(<target> PUBLIC <definition>), I believe these should be automatically exported and defined in other projects through ament.

[thomasemter]

Hi @oysstu ,

thanks for the hint. I'm not sure why we would export these, though. They are just used internally as compiler directives.

[oysstu]

They are exposed through the header files. In other words, to use ROSaicNode in a ROS2 executor using static composition (i.e., not through composable nodes), the rosaic_node.hpp header has to be included, which fails without these definitions.

There's probably more examples, but the abstraction/typedefs.hpp header is one of the headers that need ROS2_VER_N250 to be defined which is indirectly included by rosaic_node.hpp.

[thomasemter]

Ah, thank you so much for the explanation. We will change it.