Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch password hashing algorithm #27

Open
Pryx opened this issue Apr 14, 2018 · 5 comments
Open

Switch password hashing algorithm #27

Pryx opened this issue Apr 14, 2018 · 5 comments
Assignees

Comments

@Pryx
Copy link
Collaborator

Pryx commented Apr 14, 2018

When I implemented the password hashing and verification algorithm, I used older method of doing that. I don't know whether any of the current users use PHP < 5.5 but I haven't seen anything below 5.5 for a while that wasn't up-gradable to 5.5 or higher. Let me know if you need me to support PHP < 5.5 or if I can switch to password_hash method.

@Pryx Pryx added this to the 1.2.0 milestone Apr 14, 2018
@Pryx Pryx self-assigned this Apr 14, 2018
@jhuesser
Copy link
Contributor

jhuesser commented Jun 6, 2018

If you switch the hashing algorithm, will you then stop emailing passwords in clear text too? Because regarding security this is a no go. https://security.stackexchange.com/questions/17979/is-sending-password-to-user-email-secure

But regardles this is a real cool project, thank you for your work!

@Pryx
Copy link
Collaborator Author

Pryx commented Jun 6, 2018

Mailing passwords is intended behavior right now, because it is only meant to be one time password (I'm pretty sure the email says that they should change it ASAP). This could be mitigated by having some checks in place - for example that the user would need to change password after first login. We could of course skip the mailing completely and have the admin give password to the user via a secure channel. What would be your preferred behavior? As this was at first intended to be only a school project I didn't give security much thought 🙂

@jhuesser
Copy link
Contributor

jhuesser commented Jun 6, 2018

I see :) Yeah, the email says it should be change ASAP, but unfortunately most of the users don't...

I would recommend something, that is seen quite often (eg. WordPress):

  1. admin creates new user. He can decide if the user should set the password or if the admin does.
  2. if the user sets the password a link with a token to set the password is sent to him (like the lost password function).

@thnilsen
Copy link
Contributor

Just a thought... Would it not make sense to follow PHP versions end of life paradigm? 5.6 will no longer be supported after 31st of Dec 2018. PHP 7.1 will be the oldest version supported after Jan 2019, so it would be normal to only support 7.1 and 7.2 from that date on...

Ref: http://php.net/supported-versions.php

@Pryx
Copy link
Collaborator Author

Pryx commented Nov 21, 2018

Yes that would make sense, I wanted the script to run everywhere and some hosting providers are pretty lazy to update PHP versions. But supporting 5.6+ would definitely make sense.

@Pryx Pryx removed this from the 1.2.0 milestone May 22, 2020
@Pryx Pryx added the pinned label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants