Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MutableHandle::new should be pub(crate) #552

Open
gterzian opened this issue Jan 22, 2025 · 1 comment
Open

MutableHandle::new should be pub(crate) #552

gterzian opened this issue Jan 22, 2025 · 1 comment

Comments

@gterzian
Copy link
Member

pub(crate) fn new(ptr: &'a T) -> Self {

is private to this crate, but

pub fn new(ptr: &'a mut T) -> Self {

is not. I assume both should be private to this crate(In both cases one should not directly call new, but rather use set on a newly rooted undefined value?).

@jdm
Copy link
Member

jdm commented Jan 23, 2025

Yep, that looks like the right fix to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants