Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USWDS package to 3.0 #153

Open
fwextensions opened this issue Jun 30, 2022 · 1 comment
Open

Update USWDS package to 3.0 #153

fwextensions opened this issue Jun 30, 2022 · 1 comment
Labels
chore General maintenance tasks

Comments

@fwextensions
Copy link
Collaborator

fwextensions commented Jun 30, 2022

Sass has deprecated @import in favor of @use, which v3 of the package is using.

https://designsystem.digital.gov/documentation/migration/
https://designsystem.digital.gov/documentation/settings/

@fwextensions
Copy link
Collaborator Author

fwextensions commented Jul 12, 2022

This branch tries to address this, but it doesn't fully work. npm run sass compiles okay, but the sass command in Procfile.dev throws an error about not being able to find the file to import. The same thing happens with webpack in docker.

It may be possible to fix this by changing how the h1 - h4 mixins get overwritten in _uswds-theme-custom-mixins.scss, so that @forward and @use can be used. But lots of component styles include those mixins, and it's not clear what the right way of handling it is.

All in all, trying to update to 3.0 seems like a real sass-ache.

@fwextensions fwextensions added the chore General maintenance tasks label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General maintenance tasks
Projects
None yet
Development

No branches or pull requests

1 participant